Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lightbox for all #26847

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Enable Lightbox for all #26847

merged 1 commit into from
Jan 29, 2024

Conversation

mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Jan 25, 2024

What is the value of this and can you measure success?

Make all our users who want the lighbox, including @paperboyo, happy!

What does this change?

Turn the Lightbox experiment into a feature switch

Checklist

@mxdvl mxdvl marked this pull request as ready for review January 25, 2024 15:32
@mxdvl mxdvl requested a review from a team as a code owner January 25, 2024 15:32
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

Copy link
Member

@arelra arelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖼️

@mxdvl mxdvl merged commit 456ae88 into main Jan 29, 2024
2 checks passed
@mxdvl mxdvl deleted the mxdvl/lightbox-for-all branch January 29, 2024 16:36
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @mxdvl 12 minutes and 11 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @mxdvl 12 minutes and 25 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants